Simplify NativeHashedStorageHandler() #4199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
This avoids an opportunity for type(system) confusion, by always using the full CompilerType instead of assuming that the type system hasn't changed in CreateTupleType and GetCanononicalType(). Also the call to GetCanonicalType() and IsTupleType was redundant. Unfortunately I was not able to construct a reproducer for the type confusion using a REPL-defined alias type, but I received a crashlog that seems indicate that it's indeed possible.
Note that it's entirely unclear to me under which conditions GetMemberVariableOffset() would fail and GetByteStride would succeed.
kastiglione
approved these changes
Apr 8, 2022
kastiglione
reviewed
Apr 8, 2022
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids an opportunity for type(system) confusion, by always using
the full CompilerType instead of assuming that the type system hasn't
changed in CreateTupleType and GetCanononicalType(). Also the call to
GetCanonicalType() and IsTupleType was redundant.
Unfortunately I was not able to construct a reproducer for the type
confusion using a REPL-defined alias type, but I received a crashlog
that seems indicate that it's indeed possible.
rdar://[91291458