Skip to content

Commit 172f8fa

Browse files
committed
[lldb] Removed scoped timer from ReadMemoryFromFileCache
`ReadMemoryFromFileCache` can be called at a high rate, and has fast execution. Signposts for high rate & brief duration can have a negative impact on tracing; emitting a high volume signposts can lead to blocking, affecting performance, and total volume makes human review of the trace harder because of the noise. Differential Revision: https://reviews.llvm.org/D121226 (cherry picked from commit 94bda3a)
1 parent 8e1a758 commit 172f8fa

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lldb/source/Target/Target.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1734,7 +1734,6 @@ bool Target::ModuleIsExcludedForUnconstrainedSearches(
17341734

17351735
size_t Target::ReadMemoryFromFileCache(const Address &addr, void *dst,
17361736
size_t dst_len, Status &error) {
1737-
LLDB_SCOPED_TIMER();
17381737
SectionSP section_sp(addr.GetSection());
17391738
if (section_sp) {
17401739
// If the contents of this section are encrypted, the on-disk file is

0 commit comments

Comments
 (0)