Skip to content

Commit 2b416b4

Browse files
committed
[libcxx][CI][AIX] Switch to LLVM_ENABLE_RUNTIMES
and to the new `runtimes` top level CMakeLists.txt since the old path is now deprecated. This requires a slight adjustment of the libcxxabi CMake, since there are required macro definitions we previously got via the `llvm/CMakeList.txt` path. Reviewed By: ldionne, #libc, #libc_abi Differential Revision: https://reviews.llvm.org/D113403
1 parent 6facafe commit 2b416b4

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.static/hardware_concurrency.pass.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
//===----------------------------------------------------------------------===//
88
//
99
// UNSUPPORTED: libcpp-has-no-threads
10-
// XFAIL: LIBCXX-AIX-FIXME
1110

1211
// <thread>
1312

libcxx/utils/ci/run-buildbot

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,6 @@ function generate-cmake-libcxx-win() {
113113
"${@}"
114114
}
115115

116-
function generate-cmake-aix() {
117-
generate-cmake-base \
118-
-S "${MONOREPO_ROOT}/llvm" \
119-
-DLLVM_ENABLE_PROJECTS="libcxx;libcxxabi" \
120-
"${@}"
121-
}
122-
123116
function check-runtimes() {
124117
echo "--- Installing libc++, libc++abi and libunwind to a fake location"
125118
${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi install-unwind
@@ -623,9 +616,10 @@ aix)
623616
export CC=ibm-clang
624617
export CXX=ibm-clang++_r
625618
clean
626-
generate-cmake-aix -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AIX.cmake" \
619+
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AIX.cmake" \
627620
-DLIBCXX_TEST_CONFIG="ibm-libc++-shared.cfg.in" \
628-
-DLIBCXXABI_TEST_CONFIG="ibm-libc++abi-shared.cfg.in"
621+
-DLIBCXXABI_TEST_CONFIG="ibm-libc++abi-shared.cfg.in" \
622+
-DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"
629623
# TODO: use check-runtimes once libunwind builds cleanly on AIX.
630624
${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi
631625
${NINJA} -vC "${BUILD_DIR}" check-cxx check-cxxabi

libcxxabi/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,12 @@ string(REPLACE ";" " " LIBCXXABI_CXX_FLAGS "${LIBCXXABI_CXX_FLAGS}")
519519
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${LIBCXXABI_CXX_FLAGS}")
520520
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${LIBCXXABI_C_FLAGS}")
521521

522+
# On AIX, avoid picking up VMX extensions(i.e. vec_malloc) which would change
523+
# the default alignment of the allocators here.
524+
if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
525+
add_definitions("-D_XOPEN_SOURCE=700")
526+
endif()
527+
522528
#===============================================================================
523529
# Setup Source Code
524530
#===============================================================================

0 commit comments

Comments
 (0)