Skip to content

Commit 402bf28

Browse files
committed
[NFC][InstCombine] Fixup commutative/negative tests with icmp preds in @llvm.umul.with.overflow tests
llvm-svn: 366802
1 parent 4153f17 commit 402bf28

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

llvm/test/Transforms/InstCombine/unsigned-mul-lack-of-overflow-check-via-udiv-of-allones.ll

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ define i1 @t3_commutative(i8 %x) {
4545
; CHECK-LABEL: @t3_commutative(
4646
; CHECK-NEXT: [[T0:%.*]] = udiv i8 -1, [[X:%.*]]
4747
; CHECK-NEXT: [[Y:%.*]] = call i8 @gen8()
48-
; CHECK-NEXT: [[R:%.*]] = icmp ult i8 [[Y]], [[T0]]
48+
; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[Y]], [[T0]]
4949
; CHECK-NEXT: ret i1 [[R]]
5050
;
5151
%t0 = udiv i8 -1, %x
5252
%y = call i8 @gen8()
53-
%r = icmp ult i8 %y, %t0 ; swapped
53+
%r = icmp ule i8 %y, %t0 ; swapped
5454
ret i1 %r
5555
}
5656

@@ -89,19 +89,17 @@ define i1 @n6_wrong_pred0(i8 %x, i8 %y) {
8989
; CHECK-NEXT: ret i1 [[R]]
9090
;
9191
%t0 = udiv i8 -1, %x
92-
%r = icmp ule i8 %t0, %y
92+
%r = icmp ule i8 %t0, %y ; not uge
9393
ret i1 %r
9494
}
9595

96-
define i1 @n6_wrong_pred1(i8 %x) {
96+
define i1 @n6_wrong_pred1(i8 %x, i8 %y) {
9797
; CHECK-LABEL: @n6_wrong_pred1(
9898
; CHECK-NEXT: [[T0:%.*]] = udiv i8 -1, [[X:%.*]]
99-
; CHECK-NEXT: [[Y:%.*]] = call i8 @gen8()
100-
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[Y]], [[T0]]
99+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[T0]], [[Y:%.*]]
101100
; CHECK-NEXT: ret i1 [[R]]
102101
;
103102
%t0 = udiv i8 -1, %x
104-
%y = call i8 @gen8()
105-
%r = icmp ugt i8 %y, %t0 ; swapped
103+
%r = icmp ugt i8 %t0, %y ; not uge
106104
ret i1 %r
107105
}

llvm/test/Transforms/InstCombine/unsigned-mul-overflow-check-via-udiv-of-allones.ll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ define i1 @t3_commutative(i8 %x) {
4545
; CHECK-LABEL: @t3_commutative(
4646
; CHECK-NEXT: [[T0:%.*]] = udiv i8 -1, [[X:%.*]]
4747
; CHECK-NEXT: [[Y:%.*]] = call i8 @gen8()
48-
; CHECK-NEXT: [[R:%.*]] = icmp uge i8 [[Y]], [[T0]]
48+
; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[Y]], [[T0]]
4949
; CHECK-NEXT: ret i1 [[R]]
5050
;
5151
%t0 = udiv i8 -1, %x
5252
%y = call i8 @gen8()
53-
%r = icmp uge i8 %y, %t0 ; swapped
53+
%r = icmp ugt i8 %y, %t0 ; swapped
5454
ret i1 %r
5555
}
5656

@@ -89,7 +89,7 @@ define i1 @n6_wrong_pred0(i8 %x, i8 %y) {
8989
; CHECK-NEXT: ret i1 [[R]]
9090
;
9191
%t0 = udiv i8 -1, %x
92-
%r = icmp ule i8 %t0, %y
92+
%r = icmp ule i8 %t0, %y ; not ult
9393
ret i1 %r
9494
}
9595

@@ -100,6 +100,6 @@ define i1 @n6_wrong_pred1(i8 %x, i8 %y) {
100100
; CHECK-NEXT: ret i1 [[R]]
101101
;
102102
%t0 = udiv i8 -1, %x
103-
%r = icmp ugt i8 %t0, %y
103+
%r = icmp ugt i8 %t0, %y ; not ult
104104
ret i1 %r
105105
}

0 commit comments

Comments
 (0)