Skip to content

Commit 51ed999

Browse files
committed
[lldb] Rename DemangleWithRichManglingInfo to GetRichManglingInfo (NFC)
This addresses Pavel's comment from D118814. (cherry picked from commit edbb0f6)
1 parent 9902e36 commit 51ed999

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

lldb/include/lldb/Core/Mangled.h

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,9 @@ class Mangled {
236236
/// Function signature for filtering mangled names.
237237
using SkipMangledNameFn = bool(llvm::StringRef, ManglingScheme);
238238

239-
/// Trigger explicit demangling to obtain rich mangling information. This is
240-
/// optimized for batch processing while populating a name index. To get the
241-
/// pure demangled name string for a single entity, use GetDemangledName()
242-
/// instead.
239+
/// Get rich mangling information. This is optimized for batch processing
240+
/// while populating a name index. To get the pure demangled name string for
241+
/// a single entity, use GetDemangledName() instead.
243242
///
244243
/// For names that match the Itanium mangling scheme, this uses LLVM's
245244
/// ItaniumPartialDemangler. All other names fall back to LLDB's builtin
@@ -258,8 +257,8 @@ class Mangled {
258257
///
259258
/// \return
260259
/// True on success, false otherwise.
261-
bool DemangleWithRichManglingInfo(RichManglingContext &context,
262-
SkipMangledNameFn *skip_mangled_name);
260+
bool GetRichManglingInfo(RichManglingContext &context,
261+
SkipMangledNameFn *skip_mangled_name);
263262

264263
/// Try to identify the mangling scheme used.
265264
/// \param[in] name

lldb/source/Core/Mangled.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,8 @@ static char *GetRustV0DemangledStr(const char *M) {
221221

222222
// Explicit demangling for scheduled requests during batch processing. This
223223
// makes use of ItaniumPartialDemangler's rich demangle info
224-
bool Mangled::DemangleWithRichManglingInfo(
225-
RichManglingContext &context, SkipMangledNameFn *skip_mangled_name) {
224+
bool Mangled::GetRichManglingInfo(RichManglingContext &context,
225+
SkipMangledNameFn *skip_mangled_name) {
226226
// Others are not meant to arrive here. ObjC names or C's main() for example
227227
// have their names stored in m_demangled, while m_mangled is empty.
228228
assert(m_mangled);

lldb/source/Symbol/Symtab.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ void Symtab::InitNameIndexes() {
330330

331331
const SymbolType type = symbol->GetType();
332332
if (type == eSymbolTypeCode || type == eSymbolTypeResolver) {
333-
if (mangled.DemangleWithRichManglingInfo(rmc, lldb_skip_name)) {
333+
if (mangled.GetRichManglingInfo(rmc, lldb_skip_name)) {
334334
RegisterMangledNameEntry(value, class_contexts, backlog, rmc);
335335
continue;
336336
}

0 commit comments

Comments
 (0)