Skip to content

Commit 76fd286

Browse files
JDevlieghereazharudd
authored andcommitted
[clang] Disable assertion that can "easily happen"
Disable the assertion for getting a module ID for non-local, non-imported module. According to the FIXME this can "easily happen" and indeed, we're hitting this assertion regularly. Disable it until it can be properly investigated. rdar://99352728 Differential revision: https://reviews.llvm.org/D136290 (cherry picked from commit 97b9130)
1 parent 43d2dfd commit 76fd286

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

clang/lib/Serialization/ASTWriter.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2735,12 +2735,12 @@ unsigned ASTWriter::getLocalOrImportedSubmoduleID(const Module *Mod) {
27352735
}
27362736

27372737
unsigned ASTWriter::getSubmoduleID(Module *Mod) {
2738+
unsigned ID = getLocalOrImportedSubmoduleID(Mod);
27382739
// FIXME: This can easily happen, if we have a reference to a submodule that
27392740
// did not result in us loading a module file for that submodule. For
27402741
// instance, a cross-top-level-module 'conflict' declaration will hit this.
2741-
unsigned ID = getLocalOrImportedSubmoduleID(Mod);
2742-
assert((ID || !Mod) &&
2743-
"asked for module ID for non-local, non-imported module");
2742+
// assert((ID || !Mod) &&
2743+
// "asked for module ID for non-local, non-imported module");
27442744
return ID;
27452745
}
27462746

0 commit comments

Comments
 (0)