Skip to content

Commit 8cc8bcb

Browse files
Merge pull request #7937 from rastogishubham/FormParamStable
Cherry-pick PR #7912 into stable/20230725
2 parents 76c678c + 145bbc7 commit 8cc8bcb

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

llvm/lib/MCCAS/MCCASObjectV1.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3113,6 +3113,7 @@ struct DIEVisitor {
31133113
ArrayRef<AbbrevContent> DIEContents);
31143114
Error materializeAbbrevDIE(unsigned AbbrevIdx);
31153115

3116+
uint16_t DwarfVersion;
31163117
SmallVector<AbbrevEntry> AbbrevEntryCache;
31173118
ArrayRef<StringRef> AbbrevEntries;
31183119
BinaryStreamReader DistinctReader;
@@ -3131,8 +3132,8 @@ Error DIEVisitor::visitDIEAttrs(BinaryStreamReader &DataReader,
31313132
ArrayRef<AbbrevContent> DIEContents) {
31323133
constexpr auto IsLittleEndian = true;
31333134
constexpr auto AddrSize = 8;
3134-
constexpr auto FormParams =
3135-
dwarf::FormParams{4 /*Version*/, AddrSize, dwarf::DwarfFormat::DWARF32};
3135+
auto FormParams =
3136+
dwarf::FormParams{DwarfVersion, AddrSize, dwarf::DwarfFormat::DWARF32};
31363137

31373138
for (auto Contents : DIEContents) {
31383139
bool DataInDistinct = Contents.FormInDistinctData;
@@ -3242,8 +3243,8 @@ static std::optional<uint8_t> getNonULEBFormSize(dwarf::Form Form,
32423243

32433244
Error DIEVisitor::materializeAbbrevDIE(unsigned AbbrevIdx) {
32443245
constexpr auto AddrSize = 8;
3245-
constexpr auto FormParams =
3246-
dwarf::FormParams{4 /*Version*/, AddrSize, dwarf::DwarfFormat::DWARF32};
3246+
auto FormParams =
3247+
dwarf::FormParams{DwarfVersion, AddrSize, dwarf::DwarfFormat::DWARF32};
32473248

32483249
AbbrevEntryReader AbbrevReader =
32493250
getAbbrevEntryReader(AbbrevEntries, AbbrevIdx);
@@ -3422,7 +3423,8 @@ Error mccasformats::v1::visitDebugInfo(
34223423
HeaderCallback(toStringRef(HeaderData));
34233424

34243425
append_range(TotAbbrevEntries, LoadedTopRef->AbbrevEntries);
3425-
DIEVisitor Visitor{{},
3426+
DIEVisitor Visitor{DwarfVersion,
3427+
{},
34263428
TotAbbrevEntries,
34273429
DistinctReader,
34283430
UncompressedDistinctData,

0 commit comments

Comments
 (0)