Make FormParams have the correct DWARF version. #7912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test llvm |
|
@swift-ci please test |
rastogishubham
force-pushed
the
FormParam
branch
from
75ae847 to
0b24246
Compare
felipepiovezan
approved these changes
Dec 21, 2023
llvm/lib/MCCAS/MCCASObjectV1.cpp
Outdated
| @@ -3143,8 +3144,8 @@ Error DIEVisitor::visitDIEAttrs(BinaryStreamReader &DataReader, | |||
| ArrayRef<AbbrevContent> DIEContents) { | |||
| constexpr auto IsLittleEndian = true; | |||
| constexpr auto AddrSize = 8; | |||
| constexpr auto FormParams = | |||
| dwarf::FormParams{4 /*Version*/, AddrSize, dwarf::DwarfFormat::DWARF32}; | |||
| auto FormParams = dwarf::FormParams{DwarfVersion /*Version*/, AddrSize, | |||
There was a problem hiding this comment.
I guess we don't need the inline comment anymore :)
llvm/lib/MCCAS/MCCASObjectV1.cpp
Outdated
| @@ -3254,8 +3255,8 @@ static std::optional<uint8_t> getNonULEBFormSize(dwarf::Form Form, | |||
|
|
|||
| Error DIEVisitor::materializeAbbrevDIE(unsigned AbbrevIdx) { | |||
| constexpr auto AddrSize = 8; | |||
| constexpr auto FormParams = | |||
| dwarf::FormParams{4 /*Version*/, AddrSize, dwarf::DwarfFormat::DWARF32}; | |||
| auto FormParams = dwarf::FormParams{DwarfVersion /*Version*/, AddrSize, | |||
rastogishubham
force-pushed
the
FormParam
branch
from
0b24246 to
f6ef32d
Compare
rastogishubham
force-pushed
the
FormParam
branch
from
f6ef32d to
d5d1861
Compare
|
@swift-ci please test llvm |
rastogishubham
added a commit
that referenced
this pull request
Jan 5, 2024
Cherry-pick PR #7912 into stable/20230725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this comment #7852 (comment)