Revert "[mlir] Add baseAttr to TypedArrayAttrBase."

ftynse · ftynse · commit c8695ba9cdeb · 2020-01-23T14:47:11.000+01:00
This reverts commit eec3690. This modeling is incorrect. baseAttr is intended for attribute decorators that are not backed by C++ attribute classes. It essentially says DerivedAttr isa BaseAttr, which is wrong for ArrayAttr classes. If one needs to store the element type, it should be stored as a separate filed in the tablegen class.
diff --git a/mlir/include/mlir/IR/OpBase.td b/mlir/include/mlir/IR/OpBase.td
@@ -1091,8 +1091,6 @@ class TypedArrayAttrBase<Attr element, string description>: ArrayAttrBase<
                           "; })">]>,
     description> {
   let constBuilderCall = "$_builder.getArrayAttr($0)";
-
-  let baseAttr = element;
 }
 
 def I32ArrayAttr : TypedArrayAttrBase<I32Attr,

Original file line number	Diff line number	Diff line change
`@@ -1091,8 +1091,6 @@ class TypedArrayAttrBase<Attr element, string description>: ArrayAttrBase<`
`1091`	`1091`	`"; })">]>,`
`1092`	`1092`	`description> {`
`1093`	`1093`	`let constBuilderCall = "$_builder.getArrayAttr($0)";`
`1094`		`-`
`1095`		`- let baseAttr = element;`
`1096`	`1094`	`}`
`1097`	`1095`
`1098`	`1096`	`def I32ArrayAttr : TypedArrayAttrBase<I32Attr,`