Fix TypeCoupledDeclRefInfo (de-)serialization bug #10009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test llvm |
|
@swift-ci test |
There were two issues here: 1) Deserialization relied on a specific argument evaluation order, which is unspecified. 2) IsMember was not (de-)serialized.
rapidsna
force-pushed
the
fix-tcdri-serialization-2
branch
from
83c0063 to
6aa0c1e
Compare
|
@swift-ci test llvm |
|
@swift-ci test |
hnrklssn
approved these changes
Feb 12, 2025
delcypher
pushed a commit
to delcypher/apple-llvm-project
that referenced
this pull request
May 22, 2025
These test cases use clang modules. TypeCoupledDeclRefInfo serialization/deserialization is currently broken on Linux, so disable these tests until it's been resolved. This a cherry-pick of a change that was originally landed in swiftlang#10009 origianlly. rdar://144275431 (cherry picked from commit 9fbb19c)
delcypher
pushed a commit
to delcypher/apple-llvm-project
that referenced
this pull request
May 22, 2025
* Unguard tests that were crashing on Linux * Fix TypeCoupledDeclRefInfo (de-)serialization bug There were two issues here: 1) Deserialization relied on a specific argument evaluation order, which is unspecified. 2) IsMember was not (de-)serialized. This problem was originally tracked by rdar://144275431 and rdar://151820159 tracks landing the missing cherry-pick to the `next` branch. (cherry picked from commit aeb1272)
delcypher
pushed a commit
that referenced
this pull request
May 22, 2025
These test cases use clang modules. TypeCoupledDeclRefInfo serialization/deserialization is currently broken on Linux, so disable these tests until it's been resolved. This a cherry-pick of a change that was originally landed in #10009 origianlly. rdar://144275431 (cherry picked from commit 9fbb19c)
delcypher
pushed a commit
that referenced
this pull request
May 22, 2025
* Unguard tests that were crashing on Linux * Fix TypeCoupledDeclRefInfo (de-)serialization bug There were two issues here: 1) Deserialization relied on a specific argument evaluation order, which is unspecified. 2) IsMember was not (de-)serialized. This problem was originally tracked by rdar://144275431 and rdar://151820159 tracks landing the missing cherry-pick to the `next` branch. (cherry picked from commit aeb1272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deserialization logic for
TypeCoupledDeclRefInfohad two issues.1) Deserialization relied on a specific argument evaluation order, which is unspecified.
2) IsMember was not (de-)serialized.