[SUA][Coroutines] Change LLVM's Coroutine lowering to allow for and use extra hash parameter to llvm.coro.id.retcon.once and llvm.coro.id.retcon #10015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se extra hash parameter to llvm.coro.id.retcon.once and llvm.coro.id.retcon Change the signatures of llvm.coro.id.retcon.once and llvm.coro.id.retcon to pass a hash parameter as a variable argument. This change will allow IRGen to pass the new runtime function swift_coroFrameAlloc (which calls the typed allocator if TMO is enabled) along with a type hash to these two intrinsics. rdar://141236876
t-rasmud
requested review from
aschwaighofer,
mikeash,
fbigarella,
yln and
devincoughlin
|
@swift-ci test |
aschwaighofer
requested changes
Feb 13, 2025
|
@swift-ci test llvm |
|
Merging the PR. Happy to address any post-commit feedback. |
t-rasmud
added a commit
that referenced
this pull request
Feb 16, 2025
…se extra hash parameter to llvm.coro.id.retcon.once and llvm.coro.id.retcon (#10015) [SUA][Coroutines] Change LLVM's Coroutine lowering to allow for and use extra hash parameter to llvm.coro.id.retcon.once and llvm.coro.id.retcon Change the signatures of llvm.coro.id.retcon.once and llvm.coro.id.retcon to pass a hash parameter as a variable argument. This change will allow IRGen to pass the new runtime function swift_coroFrameAlloc (which calls the typed allocator if TMO is enabled) along with a type hash to these two intrinsics. rdar://141236876 (cherry picked from commit fe25ae6)
bnbarham
added a commit
that referenced
this pull request
Feb 22, 2025
[SUA][Coroutines] Change LLVM's Coroutine lowering to allow for and use extra hash parameter to llvm.coro.id.retcon.once and llvm.coro.id.retcon (#10015)
t-rasmud
added a commit
that referenced
this pull request
Mar 19, 2025
…once intrinsic The signature of coro.id.retcon.once intrinsic was modified in #10015 with an extra vararg. This commit adds an auto upgrader to LLVM in order to be compatible with compilers generating old bitcode (intrinsic without the vararg). rdar://147426562
t-rasmud
added a commit
that referenced
this pull request
Mar 22, 2025
…once intrinsic The signature of coro.id.retcon.once intrinsic was modified in #10015 with an extra vararg. This commit adds an auto upgrader to LLVM in order to be compatible with compilers generating old bitcode (intrinsic without the vararg). rdar://147426562
t-rasmud
added a commit
that referenced
this pull request
Apr 25, 2025
…once intrinsic The signature of coro.id.retcon.once intrinsic was modified in #10015 with an extra vararg. This commit adds an auto upgrader to LLVM in order to be compatible with compilers generating old bitcode (intrinsic without the vararg). rdar://147426562 (cherry picked from commit 969660b) (cherry picked from commit 2eaa148) (cherry picked from commit 889ce26) (cherry picked from commit 031baa1) (cherry picked from commit 98dd062)
t-rasmud
added a commit
that referenced
this pull request
Apr 27, 2025
…once intrinsic The signature of coro.id.retcon.once intrinsic was modified in #10015 with an extra vararg. This commit adds an auto upgrader to LLVM in order to be compatible with compilers generating old bitcode (intrinsic without the vararg). rdar://147426562 (cherry picked from commit 969660b) (cherry picked from commit 2eaa148) (cherry picked from commit 889ce26) (cherry picked from commit 031baa1) (cherry picked from commit 98dd062)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the signatures of llvm.coro.id.retcon.once and llvm.coro.id.retcon to pass a hash parameter as a variable argument. This change will allow IRGen to pass the new runtime function swift_coroFrameAlloc (which calls the typed allocator if TMO is enabled) along with a type hash to these two intrinsics.
rdar://141236876