Add Dropped Variable Statistics for MIR #10019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[NFC] Move DroppedVariableStats to its own file and redesign it to be extensible. (llvm#115563) Move DroppedVariableStats code to its own file and change the class to have an extensible design so that we can use it to add dropped statistics to MIR passes and the instruction selector. (cherry picked from commit 5717a99)
Debugging the dropped variable statistics for large LLVM IR files can be made easier if the functions called before an optimization pass is run includes the PassID of the pass that will be run after statistics metrics are collected. This patch adds that support. (cherry picked from commit 12903fb)
This patch attempts to reland llvm#120780 while addressing the issues that caused the patch to be reverted. Namely: 1. The patch had included code from the llvm/Passes directory in the llvm/CodeGen directory. 2. The patch increased the backend compile time by 2% due to adding a very expensive include in MachineFunctionPass.h The patch has been re-structured so that there is no dependency between the llvm/Passes and llvm/CodeGen directory, by moving the base class, `class DroppedVariableStats` to the llvm/IR directory. The expensive include in MachineFunctionPass.h has been changed to contain forward declarations instead of other header includes which was pulling a ton of code into MachineFunctionPass.h and should resolve any issues when it comes to compile time increase. (cherry picked from commit 92f916f)
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for dropped variable statistics in MIR.
It cherry-picks:
8c5a048: This patch moved the
class DroppedVariableStatscode to it's own file and be extensible. It also introducedclass DroppedVariableStatsIRthat calculates dropped statistics to IR.7cfb292: This patch moved the
class DroppedVariableStatsIRcode to it's own file.0622cd2: This patch adds a PassID to the
runOnFunctionandrunOnModulefunctions as an argument for easier debuggability.and 999a765: This patch adds
class DroppedVariableStatsMIRto calculate dropped variable statistics in MIR. It also movesclass DroppedVariableStatsandclass DroppedVariableStatsIRcode to the llvm/IR lib