[lldb] Fix dynamic type resolution for ObjC protocol existentials #10033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
augusto2112
force-pushed
the
fix-objc-protocol
branch
from
82156a9 to
3152b1e
Compare
|
@swift-ci test |
An existential whose protocol type is an Objective-C protocol is not passed in an existential container, but as a plain old instance pointer. This patch dynamic type resolution failing for those types. rdar://144028358
augusto2112
force-pushed
the
fix-objc-protocol
branch
from
3152b1e to
419a0bb
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Feb 18, 2025
| @@ -1575,22 +1575,47 @@ swift::Demangle::NodePointer TypeSystemSwiftTypeRef::GetDemangleTreeForPrinting( | |||
| return GetNodeForPrintingImpl(dem, node, flavor, resolve_objc_module); | |||
| } | |||
|
|
|||
| /// Determine wether this demangle tree contains a node of kind \c kind. | |||
| /// Determine wether this demangle tree contains a node of kind \c kind and with | |||
| /// text \c text (if provided). | |||
| static bool Contains(swift::Demangle::NodePointer node, | |||
There was a problem hiding this comment.
Side note: this looks dangerous to me, since any type could appear in a parameter of a function type...
There was a problem hiding this comment.
Sorry I don't understand the comment. How can this break with a function type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An existential whose protocol type is an Objective-C protocol is not passed in an existential container, but as a plain old instance pointer. This patch dynamic type resolution failing for those types.
rdar://144028358