[lldb] Fix new thread detection mechanism #10064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jimingham
reviewed
Feb 19, 2025
| @@ -151,6 +151,11 @@ class ThreadList : public ThreadCollection { | |||
| std::vector<lldb::tid_t> m_expression_tid_stack; | |||
|
|
|||
| private: | |||
| /// Returns true if the current ThreadPlan of any threads requested | |||
| /// StopOthers. This ignores OS Plugin threads that are not currently backed | |||
| /// by any real thread. | |||
There was a problem hiding this comment.
I suspect the authors original intent was that "if there is no backing thread, this thread is probably not going to run?". I'm not sure
…cution (llvm#120817) These changes are designed to not change any behavior, but to make it easy to add code to choose the direction of execution after we've identified which thread(s) to run but before we add any `ThreadPlanStepOverBreakpoint`s. And honestly I think they make the existing code a bit clearer. (cherry picked from commit d594d4c)
felipepiovezan
force-pushed
the
felipe/new_thread_detection_mechanism
branch
from
8cbf27d to
45ee7b8
Compare
|
Converted this PR into a cherry-pick of the upstream commit. |
|
@swift-ci test |
adrian-prantl
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ThreadList::WillResume, we scan the list of threads to check whether a solo run was requested. If so, we ensure that new threads can't be created and run.
However, we need to make these checks after
SetupForResumeis called, as that may push plans. For example, a thread that has only a Base Plan, but has hit a breakpoint, will enqueue a "Step Over Breakpoint" plan, which must be run in isolation.Unfortunately, it seems impossible to write a test for this.
Note: this was "fixed" by this "NFC" commit upstream: llvm#120817
I don't want to cherry pick such a major patch here; instead, I'm proposing this more targeted fix that we don't need to put into
next.