[lldb] Fix the computation of the hidden/in_user_code flag #10066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be fair, in this particular case the other error would also be kind of helpful, but decide to not show any errors with source locations pointing into the expression wrapper. |
|
@swift-ci test |
adrian-prantl
changed the title
in Swift expression evaluator diagnostics.
Before:
```
-> 11 let f = Foo()
12 bar(f)
Target 0: (test) stopped.
(lldb) p init
^
|error: initializers may only be declared within a type
╰─ error: expected '(' for initializer parameters
(lldb) b init
```
After:
```
-> 11 let f = Foo()
12 bar(f)
Target 0: (test) stopped.
(lldb) p init
˄
╰─ error: expected '(' for initializer parameters
(lldb) b init
```
adrian-prantl
force-pushed
the
145152120
branch
from
f2386d9 to
6aebdcf
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Swift expression evaluator diagnostics.
Before:
After: