[lldb][NFC] Remove downstream changes related to ThreadPlan migration #10077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial implementation of swift async stepping involved migrating
ThreadPlans from thread to thread. With the OS plugins introduced in
[1], this is no longer needed and the associated code is dead.
To find the relevant diffs, files were compared with their
upstream counterparts, and code mentioning the following concepts was
deleted:
* "synchronizing plans",
* "detached plans",
* "setting TIDs on a thread plan",
* "activating a thread plan stack".
The storage for thread plan stacks had been substantially changed
downstream to allow for the concepts above. This patch restores the
original storage data structures.
These were the files compared:
* ThreadPlanStack{.cpp, .h}
* ThreadPlan{.cpp, .h}
* Process{.cpp, .h}
[1]: swiftlang#9839
(cherry picked from commit c8c7df7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation of swift async stepping involved migrating ThreadPlans from thread to thread. With the OS plugins introduced in 1, this is no longer needed and the associated code is dead.
To find the relevant diffs, files were compared with their upstream counterparts, and code mentioning the following concepts was deleted:
The storage for thread plan stacks had been substantially changed downstream to allow for the concepts above. This patch restores the original storage data structures.
These were the files compared:
(cherry picked from commit c8c7df7)