[lldb] Avoid crashing when trying reconstruct types with errors #10119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
augusto2112 and
kastiglione
and removed request for
a team
|
@swift-ci test |
adrian-prantl
force-pushed
the
145225544
branch
from
f1e770e to
16ecf77
Compare
|
@swift-ci test |
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
augusto2112
approved these changes
Feb 26, 2025
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
adrian-prantl
force-pushed
the
145225544
branch
from
16ecf77 to
a033a31
Compare
|
@swift-ci test |
We have crash reports that can be traced back to performing type reconstruction on a mangled name with an error in it. This patch avoids this situation by not reconstructing them. Ther is nothing that would come of it anyway. rdar://145225544
adrian-prantl
force-pushed
the
145225544
branch
from
a033a31 to
ea373e6
Compare
|
@swift-ci test |
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have crash reports that can be traced back to performing type reconstruction on a mangled name with an error in it. This patch avoids this situation by not reconstructing them. Ther is nothing that would come of it anyway.
rdar://145225544