[Coro] Add variant of retcon.once ABI. #10120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
coro-retcon-dynamic
branch
3 times, most recently
from
ceca1b5 to
848bf08
Compare
| case coro::ABI::Async: | ||
| llvm_unreachable("can't allocate memory in coro async-lowering"); | ||
| } | ||
| llvm_unreachable("Unknown coro::ABI enum"); | ||
| auto Dealloc = RetconLowering.Dealloc; |
There was a problem hiding this comment.
Do we consistently check that the switch over ABI is covered. If so I would not regress that.
aschwaighofer
approved these changes
Feb 26, 2025
Like async coroutines, it's fixed-per-function-size frame is caller allocated--the size is stored in a global "coro function pointer". Like retcon coroutines, dynamic allocations are performed via intrinsic-provided allocation and deallocation functions. Unlike both, it takes an allocator struct as an argument which is forwarded to the allocation/deallocation functions.
nate-chandler
force-pushed
the
coro-retcon-dynamic
branch
from
848bf08 to
b0e1dc9
Compare
|
@swift-ci test llvm |
|
@swift-ci test |
nate-chandler
added a commit
that referenced
this pull request
Mar 13, 2025
It became uncovered in #10120 . Fix that here.
bnbarham
pushed a commit
to bnbarham/llvm-project
that referenced
this pull request
Apr 21, 2025
It became uncovered in swiftlang#10120 . Fix that here. (cherry picked from commit 82d3bcd)
bnbarham
pushed a commit
to bnbarham/llvm-project
that referenced
this pull request
Apr 22, 2025
It became uncovered in swiftlang#10120 . Fix that here. (cherry picked from commit 82d3bcd)
bnbarham
pushed a commit
to bnbarham/llvm-project
that referenced
this pull request
Apr 23, 2025
It became uncovered in swiftlang#10120 . Fix that here. (cherry picked from commit 82d3bcd)
bnbarham
pushed a commit
to bnbarham/llvm-project
that referenced
this pull request
Apr 23, 2025
It became uncovered in swiftlang#10120 . Fix that here. (cherry picked from commit 82d3bcd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like async coroutines, its fixed-per-function-size frame is caller allocated--the size is stored in a global "coro function pointer".
Like retcon coroutines, dynamic allocations are performed via intrinsic-provided allocation and deallocation functions.
Unlike both, it takes an allocator struct as an argument which is forwarded to the allocation/deallocation functions.