Skip to content

[ValueTracking] AllowEphemerals for alignment assumptions. #10135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fhahn
Copy link

@fhahn fhahn commented Feb 28, 2025

rdar://72436671

@fhahn fhahn requested a review from a team as a code owner February 28, 2025 12:03
@fhahn
Copy link
Author

fhahn commented Feb 28, 2025

@swift-ci please test

@fhahn
Copy link
Author

fhahn commented Mar 1, 2025

@swift-ci please test

fhahn added 2 commits March 1, 2025 13:17
Precommit tests from llvm#108632.

(cherry picked from commit 383a670)
Allow AllowEphemerals in isValidAssumeForContext, as the CxtI might
be the producer of the pointer in the bundle. At the moment, align
assumptions aren't optimized away.

This allows using the assumption in the computeKnownBits call in
getConstantMultipleImpl.

We could extend the computeKnownBits API to allow callers to specify if
ephemerals are allowed, if the info from computeKnownBitsFromContext is
used to remove alignment assumptions.

PR: llvm#108632
(cherry picked from commit dce5bf8)
@fhahn fhahn force-pushed the rt-unroll-scev-alignment-assumption branch from 4bcff10 to 7878475 Compare March 1, 2025 13:18
@fhahn
Copy link
Author

fhahn commented Mar 1, 2025

@swift-ci please test

@fhahn fhahn merged commit 1b5a84a into swiftlang:stable/20240723 Mar 2, 2025
2 checks passed
@fhahn fhahn deleted the rt-unroll-scev-alignment-assumption branch March 2, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant