[lldb] Remove expensive include of Reflection.h (NFC) #10138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
felipepiovezan,
kastiglione and
augusto2112
and removed request for
a team and
felipepiovezan
|
@swift-ci test |
adrian-prantl
force-pushed
the
remove-reflection-h
branch
from
bfe49ca to
992ee4a
Compare
|
@swift-ci test |
augusto2112
approved these changes
Feb 28, 2025
felipepiovezan
approved these changes
Feb 28, 2025
kastiglione
approved these changes
Feb 28, 2025
I noticed that an unreasonable amount of files (>50) were required to recompile after changing this header, when it should have only affected 1-2 cpp files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.