[lldb] Add synthetic formatter for Swift.TaskGroup #10143
Conversation
|
|
||
| operator bool() const { return addr && addr != LLDB_INVALID_ADDRESS; } | ||
|
|
||
| static constexpr offset_t JobFlagsOffset = 0x20; |
There was a problem hiding this comment.
Are these offsets dependent on the target architecture or are they host offsets?
There was a problem hiding this comment.
I'll check. I think so, but your question made me realize I have made some assumptions that I'll need to check.
There was a problem hiding this comment.
I realized I can get rid of some of these offsets.
There was a problem hiding this comment.
@adrian-prantl on review, I think these offsets will need to be adjusted for arm64_32.
There was a problem hiding this comment.
I would try to compute them as multiples of the pointer size of the target, and in addition verify that the Swift concurrency version (there's a new special symbol for this now) on the target is still 1 and error out otherwise.
There was a problem hiding this comment.
yes this PR checks the swift concurrency version symbol.
I will merge this with 64 bit support and then setup a test for watchOS update for arm64_32 in a follow up.
|
@swift-ci test |
|
@swift-ci test |
| ) | ||
| self.expect( | ||
| "v group", | ||
| substrs=[ |
There was a problem hiding this comment.
While this probably covers it, It would be slightly better to test GetChildWithName/GetChildAtIndex/GetNumChildren separately, since they are implemented separately, too.
There was a problem hiding this comment.
Good call, I had a StringRef bug in GetIndexOfChildWithName
|
@swift-ci test |
kastiglione
deleted the
dl/lldb-Add-synthetic-formatter-for-Swift.TaskGroup
branch
Add synthetic data formatter for `TaskGroup`. This formatter prints the group's tasks using the previously added formatter for `Task`. (cherry-picked from commit 065c58e)
Add synthetic data formatter for `TaskGroup`. This formatter prints the group's tasks using the previously added formatter for `Task`. (cherry-picked from commit 065c58e)
Add synthetic data formatter for
TaskGroup. This formatter prints the group's tasks using the previously added formatter forTask.