[NFC][SafeBuffers/BoundsSafety] Fix a test that was broken in conflict merge in #10156 #10175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t merging One count on the number of a diagnostic note got lost during conflict merging. This commit fixes it.
|
@swift-ci test |
|
This PR introduced the test failure. |
|
@swift-ci please test llvm |
|
(I think LLVM Test Linux Platform is broken in a different way, so that one might still fail) |
benlangmuir
reviewed
Mar 5, 2025
| @@ -72,7 +72,7 @@ void cb_cchar_42(const char *__counted_by(42) s); | |||
| // expected-note@+1 19{{consider using a safe container and passing '.data()' to the parameter 'p' and '.size()' to its dependent parameter 'count' or 'std::span' and passing '.first(...).data()' to the parameter 'p'}} | |||
| void cb_int(int *__counted_by(count) p, size_t count); | |||
|
|
|||
| // expected-note@+1 33{{consider using a safe container and passing '.data()' to the parameter 'p' and '.size()' to its dependent parameter 'count' or 'std::span' and passing '.first(...).data()' to the parameter 'p'}} | |||
| // expected-note@+1 34{{consider using a safe container and passing '.data()' to the parameter 'p' and '.size()' to its dependent parameter 'count' or 'std::span' and passing '.first(...).data()' to the parameter 'p'}} | |||
There was a problem hiding this comment.
You don't need to change it for this PR, but maybe these checks with large counts should be changed to use + so we don't need to update them every time?
drodriguez
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One count on the number of a diagnostic note got lost during conflict merging in b5b6dce.
This commit fixes it.