Skip to content

[lldb] Add "address" member to Task formatter #10176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Mar 5, 2025

Include the Task's internal address as a member of the synthetic formatter. This is to allow the address to be used by other commands, namely language swift task {info,backtrace,select}. Those commands will be updated in followup changes.

@kastiglione kastiglione requested a review from a team as a code owner March 5, 2025 23:32
@kastiglione kastiglione changed the title dl/lldb Add address member to Task formatter [lldb] Add "address" member to Task formatter Mar 5, 2025
@kastiglione
Copy link
Author

Depends on #10169 and #10172 (only because it updates those tests).

This PR's specific changes are only the 856c685 commit.

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione
Copy link
Author

@adrian-prantl the commit specific to this PR is the 856c685 (for easier review)

@kastiglione
Copy link
Author

Merged in 095ef91 as part of #10177

@kastiglione kastiglione closed this Mar 7, 2025
@kastiglione kastiglione deleted the dl/lldb-Add-address-member-to-Task-formatter branch March 7, 2025 23:09
kastiglione added a commit that referenced this pull request Mar 8, 2025
Update the `language swift task {backtrace,select}` commands to take a task address.

This is useful in conjunction with #10176 which prints a tasks address. An example use case is printing a `TaskGroup`, and then using the address of one of the group's child tasks with either the `backtrace` or `select` command.
kastiglione added a commit that referenced this pull request Mar 11, 2025
Update the `language swift task {backtrace,select}` commands to take a task address.

This is useful in conjunction with #10176 which prints a tasks address. An example use case is printing a `TaskGroup`, and then using the address of one of the group's child tasks with either the `backtrace` or `select` command.

(cherry-picked from commit 0a0c9a6)
kastiglione added a commit that referenced this pull request Mar 11, 2025
Update the `language swift task {backtrace,select}` commands to take a task address.

This is useful in conjunction with #10176 which prints a tasks address. An example use case is printing a `TaskGroup`, and then using the address of one of the group's child tasks with either the `backtrace` or `select` command.

(cherry-picked from commit 0a0c9a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants