[lldb] Upgrade CompilerType::GetBitSize to return llvm::Expected #10192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
kastiglione,
augusto2112,
felipepiovezan and
Michael137
|
@swift-ci test |
adrian-prantl
force-pushed
the
145667239-swift
branch
from
f552a55 to
cefc65a
Compare
Michael137
approved these changes
Mar 7, 2025
adrian-prantl
force-pushed
the
145667239-swift
branch
from
cefc65a to
ace8f6c
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
…m#129601) This patch pushes the error handling boundary for the GetBitSize() methods from Runtime into the Type and CompilerType APIs. This makes it easier to diagnose problems thanks to more meaningful error messages being available. GetBitSize() is often the first thing LLDB asks about a type, so this method is particularly important for a better user experience. rdar://145667239 (cherry picked from commit 878a64f)
(cherry picked from commit 46236f4)
Followup to llvm@878a64f (cherry picked from commit 4022d78)
(cherry picked from commit 2317a72)
adrian-prantl
force-pushed
the
145667239-swift
branch
from
c5ca324 to
0c5084b
Compare
|
@swift-ci test |
adrian-prantl
merged commit 40911cc
into
swiftlang:stable/20240723
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch pushes the error handling boundary for the GetBitSize()
methods from Runtime into the Type and CompilerType APIs. This makes
it easier to diagnose problems thanks to more meaningful error
messages being available. GetBitSize() is often the first thing LLDB
asks about a type, so this method is particularly important for a
better user experience.
rdar://145667239
(cherry picked from commit 878a64f)