Skip to content

[lldb] Prevent spurious TypeRef type system validation message (NFC) #10193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

[lldb] Prevent spurious TypeRef type system validation message (NFC) #10193

merged 1 commit into from
Mar 10, 2025

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Mar 6, 2025 •
edited
Loading

This fixes the following log output:

 != 
 != 
 !=

This was happening when both the TypeRef type system (lhs) and the SwiftASTContext (rhs) produced an empty CompilerType for some operation.

@kastiglione kastiglione requested a review from a team as a code owner March 6, 2025 23:07
@kastiglione
Copy link
Author

@swift-ci test

@kastiglione kastiglione merged commit 1a9664a into stable/20240723 Mar 10, 2025
3 checks passed
@kastiglione kastiglione deleted the dl/lldb-Prevent-spurious-TypeRef-type-system-validation-message-NFC branch March 10, 2025 22:55
kastiglione added a commit that referenced this pull request Mar 11, 2025
@kastiglione
[lldb] Prevent spurious TypeRef type system validation message (NFC) (#…
b6c77e4 
…10193)

This fixes the following log output:

```
 != 
 != 
 != 
```

This was happening when both the TypeRef type system (lhs) and the SwiftASTContext (rhs) produced an empty `CompilerType` for some operation.

(cherry-picked from commit 1a9664a)
kastiglione added a commit that referenced this pull request Mar 11, 2025
@kastiglione
[lldb] Prevent spurious TypeRef type system validation message (NFC) (#…
c321cd9 
…10193)

This fixes the following log output:

```
 != 
 != 
 != 
```

This was happening when both the TypeRef type system (lhs) and the SwiftASTContext (rhs) produced an empty `CompilerType` for some operation.

(cherry-picked from commit 1a9664a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kastiglione