[lldb] Implement dynamic type resolution for embedded Swift classes #10204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
| return false; | ||
| } | ||
| if (!typeref) { | ||
| HEALTH_LOG( |
There was a problem hiding this comment.
Coming soon: we should to convert this to return llvm::Expected :-)
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
adrian-prantl
approved these changes
Mar 7, 2025
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
Although embedded Swift doesn't have any metadata, we can leverage the vtable to find out what the dynamic type of a class is. Similarly, embedded Swift only allows class existentials, so we can use the same mechanism to find out the dynamic type of those too. rdar://136615921
augusto2112
force-pushed
the
dyn-res-embed
branch
from
52bd21e to
5aab3e8
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although embedded Swift doesn't have any metadata, we can leverage the vtable to find out what the dynamic type of a class is. Similarly, embedded Swift only allows class existentials, so we can use the same mechanism to find out the dynamic type of those too.
rdar://136615921