[lldb][nfc] Adjust language plugin to changes in FilterForLineBreakpoints #10238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eakpoints (llvm#129937) This allows languages to make decisions based on the whole set of symbol contexts, giving them strictly more power than when they are only allowed to see one at a time. (cherry picked from commit fef0b8a)
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 13, 2025
felipepiovezan
merged commit 8ae58cd
into
swiftlang:stable/20240723
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the llvm commit [lldb] Let languages see all SymbolContexts at once when filtering breakpoints
Then it updates the SwiftLanguage plugin to adopt the new interface.
It is NFC: it changes the breakpoint resolver from taking one location at a time to taking all locations at once.
This will enable a future fix to how SwiftLanguage can filter unnecessary breakpoints in async functions.