[lldb][swift] Add function to extract funclet numbers #10247
Conversation
| if (node_id) | ||
| return node_id->getIndex(); |
There was a problem hiding this comment.
since I've seen all sorts of invariants break with demangled node trees, this should probably include a check to node_id->hasIndex().
| using namespace swift::Demangle; | ||
| Context ctx; | ||
| NodePointer node = SwiftLanguageRuntime::DemangleSymbolAsNode(name, ctx); | ||
| return GetFuncletNumber(node); |
There was a problem hiding this comment.
Should there be a log (perhaps verbose only) to capture symbols that fail to get a funclet number?
| return GetFuncletNumber(node); | |
| auto number = GetFuncletNumber(node); | |
| if (node && !number) | |
| LLDB_LOG(..., "could not get funclet number for mangled name {0}", name); | |
| return number; |
There was a problem hiding this comment.
The challenge with this is that the StringRef overload of this function is only used for testing.
The real users of this function will use the NodePointer overload (which is called by the StringRef overload), as they use the NodePointer for other purposes. As such, we wouldn't be logging on the most important path (there is no way to grab the name from the NodePointer).
With that in mind, I'll make sure to add logging on the next PR, the one that uses these functions to filter breakpoints.
| if (!IsSwiftMangledName(name)) | ||
| return {}; |
Async functions are broken into many pieces, and each piece is identified by an integer number in the mangling scheme. This establishes an ordering between funclets which we can exploit, in a subsequent commit, to filter out multiple breakpoints locations attributed to the same line. An exception: entry funclets don't have such a number. This commit assigns 0 to them, to better reflect the intent of ordering funclets.
felipepiovezan
force-pushed
the
felipe/funclet_number
branch
from
298995a to
9cb2811
Compare
|
@swift-ci test |
Async functions are broken into many pieces, and each piece is identified by an integer number in the mangling scheme. This establishes an ordering between funclets which we can exploit, in a subsequent commit, to filter out multiple breakpoints locations attributed to the same line.
An exception: entry funclets don't have such a number. This commit assigns 0 to them, to better reflect the intent of ordering funclets.