[Safe Buffers][BoundsSafety] Initial bounds attributes support for FAMs #10254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test llvm |
Enable parsing and syntax-level checking of bound attributes in flexible array member declarations. (rdar://139293326)
hnrklssn
reviewed
Mar 14, 2025
There was a problem hiding this comment.
Looks good! Could you add these test cases?
class FAM_THIS_ARROW_ARROW {
T *tp;
int fam[__counted_by(this->tp->count)]; // expected-error{{arrow notation not allowed for struct member in count parameter}}
};
class FAM_THIS_ARROW_DOT {
T *t;
int fam[__counted_by(this->t.count)]; // dot-expressions in counted-by is ok for FAMs
};
class FAM_ARITHMETIC {
int count;
int offset;
int fam[__counted_by(count - offset)]; // ok
};
class FAM_THIS_PTR_ARITHMETIC {
int count;
int fam[__counted_by((this + 1)->count]; // error
};
class FAM_THIS_PTR_ARITHMETIC {
int count;
int fam[__counted_by(*this.count]; // error
};
ziqingluo-90
force-pushed
the
eng/PR-139293326
branch
from
1195d74 to
2d6d738
Compare
hnrklssn
reviewed
Mar 14, 2025
clang/lib/Sema/SemaType.cpp
Outdated
| @@ -10904,7 +10911,7 @@ class CountArgChecker : public TreeTransform<CountArgChecker> { | |||
| VD->getType(), VK_LValue); | |||
| return DRE; | |||
| } | |||
|
|
|||
| BOUNDS_SAFETY_CHECK_FAM_OR_ARROW_FOR_MEMBER: | |||
There was a problem hiding this comment.
Oh an do we maybe want to extract this into a lambda or helper function instead of a goto label?
ziqingluo-90
added a commit
that referenced
this pull request
Mar 18, 2025
…Ms (#10254) Enable parsing and syntax-level checking of bound attributes in flexible array member declarations. (rdar://139293326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable parsing and syntax-level checking of bound attributes in flexible array member declarations.
(rdar://139293326)