[Coro] Delete ret.popless before rewritten return. #10274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschwaighofer
approved these changes
Mar 17, 2025
When CoroSplit rewrites returns as unreachables, look for an llvm.ret.popless intrinsic before the return and delete it. Fixes a verification error.
nate-chandler
force-pushed
the
general-coro/20250317/1
branch
from
11476e7 to
8abe108
Compare
|
@swift-ci test |
|
@swift-ci test llvm |
nate-chandler
merged commit 0a72fac
into
swiftlang:stable/20240723
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CoroSplit rewrites returns as unreachables, look for an llvm.ret.popless intrinsic before the return and delete it. Fixes a verification error.