[clang dependency scanning] C APIs for Current Working Directory Optimization #10276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on Off by Default (llvm#129809) llvm#124786 implemented current working directory (CWD) optimization and the optimization was on by default. We have discovered that build system needs to be compatible with the CWD optimization and default off is a better behavior. The build system needs to be aware that the current working directory is ignored. Without a good way of notifying the build system, it is less risky to default to off. This PR implement the change. rdar://145860213 (cherry picked from commit 7bd492f) Conflicts: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h
…mization (llvm#10146) This PR implements two new C APIs so the build system can communicate with the dependency scanner about current working directory optimization. Two new functions are added: 1. `void clang_experimental_DependencyScannerServiceOptions_setCWDOptimization(CXDependencyScannerServiceOptions Opts, int)`: the caller can use this function to set `Opts` to indicate that it can support current working directory optimization. 2. `int clang_experimental_DepGraphModule_isCWDIgnored(CXDepGraphModule)`: this function can retrieve the module info from the scanner, indicating if the current working directory is ignored for this module's context hash. As an example usage, the user of the APIs (e.g. a build system) can use them to set reasonable debug working directories for each `pcm`s. rdar://145860213 (cherry picked from commit b9c8668) Conflicts: clang/test/ClangScanDeps/cas-fs-multiple-commands.c clang/test/ClangScanDeps/include-tree-multiple-commands.c clang/tools/libclang/libclang.map
|
@swift-ci please test llvm |
|
@swift-ci please test |
|
For llvm#129809 Does this mean the optimization is off by default for swift source compiles too? If so, how will it be turned on (since it is not using the C APIs)? |
Ah good question! We have this (swiftlang/swift#79919) Swift PR to make sure the optimization is on by default. The PR has already landed in |
cyndyishida
approved these changes
Mar 18, 2025
|
The LLVM test failure ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks two PRs to implement the C APIs for Current Working Directory Optimization.
rdar://145860213