[clang][DepScan] Track modules that resolve from stable locations #10280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndyishida
changed the title
|
@swift-ci please test llvm |
|
@swift-ci please test LLVM |
|
@swift-ci please test llvm |
|
swiftlang/swift#80073 |
|
swiftlang/swift#80073 |
…locations (llvm#130634) That patch tracks whether all the file & module dependencies of a module resolve to a stable location. This information will later be queried by build systems for determining where to store the accompanying pcms. (cherry picked from commit 584f8cc)
… lookupModuleOutput callbacks, NFCI (llvm#131688) This allows clients to reference more read-only attributes, like IsInStableDirectories. (cherry picked from commit ad8f0e2)
cyndyishida
force-pushed
the
eng/PR-145776839-stable
branch
from
3963e11 to
8ec0fb8
Compare
|
swiftlang/swift#80073 |
JDevlieghere
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That patch tracks whether all the file & module dependencies of a module resolve to a stable location. This information will later be queried by build systems for determining where to store the accompanying pcms.
Additionally, pass references to ModuleDeps instead of ModuleID in lookupModuleOutput callbacks