[lldb] Add a heuristic for handling DW_AT_specification #10289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in sized containers. Due to a limitation of LLVM, the Swift frontend cannot add a DW_AT_specification attribute to a forward declaration, so it attaches it to the outer, anonymous, sized container. LLDB dutyfully follows specification attributes and collects everything into one list of attributes, which results in the anonymous container inheriting the names of the DIE linked by DW_AT_specification. This patch adds a heuristic to detect this situation. The correct thing to do here would be to fix LLVM to allow a forward declaration to have a specification, or potentially even better designate a new attribute for this.
|
test with swiftlang/swift#80078 |
augusto2112
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in sized containers. Due to a limitation of LLVM, the Swift frontend cannot add a DW_AT_specification attribute to a forward declaration, so it attaches it to the outer, anonymous, sized container. LLDB dutyfully follows specification attributes and collects everything into one list of attributes, which results in the anonymous container inheriting the names of the DIE linked by DW_AT_specification. This patch adds a heuristic to detect this situation.
The correct thing to do here would be to fix LLVM to allow a forward declaration to have a specification, or potentially even better designate a new attribute for this.