[lldb] Fix regex in TestSwiftTaskSyntheticProvider #10307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 20, 2025
| @@ -21,7 +21,7 @@ def test_top_level_task(self): | |||
| patterns=[ | |||
| textwrap.dedent( | |||
| r""" | |||
| \(Task<\(\), Error>\) task = id:(\d+) flags:(?:running\|)?enqueued\|future \{ | |||
| \(Task<\(\), Error>\) task = id:(\d+) flags:(?:running\|)?(?:enqueued\|)?future \{ | |||
There was a problem hiding this comment.
Actually, I'm still confused by this regex.
Why is the | part of the group?
What if enqueued is the last attribute?
There was a problem hiding this comment.
- the flags are in a fixed order,
enqueuedwill be afterrunning(by design) - the flags are
|separated, and ifenqueuedis present, then it will be followed by the|
There was a problem hiding this comment.
I plan to revisit these tests. This change (llvm#131475) is one of the pieces I'm working on in spare time be able to structure these tests with more easy to read regex.
There was a problem hiding this comment.
ah.. because future is always there. Makes sense.
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
kastiglione
deleted the
dl/lldb-Fix-regex-in-TestSwiftTaskSyntheticProvider
branch
kastiglione
added a commit
that referenced
this pull request
Mar 24, 2025
(cherry-picked from commit 2ec15cf)
kastiglione
added a commit
that referenced
this pull request
Mar 24, 2025
(cherry-picked from commit 2ec15cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.