Skip to content

[lldb] Construct ThreadTask fully from AsyncTaskInfo fields (NFC) #10321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

[lldb] Construct ThreadTask fully from AsyncTaskInfo fields (NFC) #10321

merged 1 commit into from
Mar 21, 2025

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Mar 21, 2025 •
edited
Loading

Instead of determining the resume function by reading memory out of the AsyncContext pointer, use the already available RunJob field of AsyncTaskInfo.

@kastiglione kastiglione requested a review from a team as a code owner March 21, 2025 18:02
@kastiglione
Copy link
Author

@swift-ci test

felipepiovezan
felipepiovezan approved these changes Mar 21, 2025
View reviewed changes
Copy link

@felipepiovezan felipepiovezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@kastiglione kastiglione merged commit e5e1999 into stable/20240723 Mar 21, 2025
3 checks passed
@kastiglione kastiglione deleted the dl/lldb-Construct-ThreadTask-fully-from-AsyncTaskInfo-fields-NFC branch March 21, 2025 22:45
kastiglione added a commit that referenced this pull request Mar 24, 2025
@kastiglione
[lldb] Construct ThreadTask fully from AsyncTaskInfo fields (NFC) (#1…
429e1f7 
…0321)

Instead of determining the resume function by reading memory out of the `AsyncContext` pointer, use the already available `RunJob` field of `AsyncTaskInfo`.

(cherry-picked from commit e5e1999)
kastiglione added a commit that referenced this pull request Mar 24, 2025
@kastiglione
[lldb] Construct ThreadTask fully from AsyncTaskInfo fields (NFC) (#1…
3ba9825 
…0321)

Instead of determining the resume function by reading memory out of the `AsyncContext` pointer, use the already available `RunJob` field of `AsyncTaskInfo`.

(cherry-picked from commit e5e1999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipepiovezan felipepiovezan felipepiovezan approved these changes

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kastiglione @felipepiovezan