[libclang] Add C interface for querying against ModuleDeps #10323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndyishida
requested review from
qiongsiwu,
Bigcheese,
benlangmuir and
jansvoboda11
cyndyishida
commented
Mar 21, 2025
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h
Outdated
Show resolved
Hide resolved
jansvoboda11
approved these changes
Mar 24, 2025
Previously the callback used for getting the output path of pcm's took in the ModuleID, which represents the name & context hash. Now that there are more attributes to determine the output path, like the attribute `isInStableDirectories`. To support this case, allow clients to override the signature of the callback to pass along a reference to the whole `ModuleDep` object instead. Additionally, this patch: * Makes calls that unwrap `CXDepGraphModule` const correct. * Provides an API to query whether a module comes from stable directories.
cyndyishida
force-pushed
the
eng/PR-147409864
branch
from
6e9647e to
fa17ed7
Compare
|
@swift-ci please test LLVM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the callback used for getting the output path of pcm's took in the ModuleID, which represents the name & context hash. Now that there are more attributes to determine the output path, like the attribute
isInStableDirectories. To support this case, allow clients to override the callback's signature to pass along a reference to the wholeModuleDepobject instead.Additionally, this patch:
CXDepGraphModuleconst correct.stable directories.