[lldb] SwiftUserExpression avoid call to ImportType (NFCi) #10376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently SwiftASTContext::ImportType was is returning a TypeSystemSwiftForExpressions TypeRef if the input is a TypeRef type. This makes future type alias resolution very slow because we lose the contextual information. By keeping it in the TypeSystemSwiftTypeRef returned by the Variable these lookups remain local. This can elminiate up to 90% of the time spent evaluating expressions in extreme cases. rdar://145884579
adrian-prantl
requested review from
augusto2112 and
kastiglione
and removed request for
a team
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SwiftASTContext::ImportType was is returning a TypeSystemSwiftForExpressions TypeRef if the input is a TypeRef type. This makes future type alias resolution very slow because we lose the contextual information. By keeping it in the TypeSystemSwiftTypeRef returned by the Variable these lookups remain local. This can elminiate up to 90% of the time spent evaluating expressions in extreme cases.
rdar://145884579