[lldb] Improve wording of Swift expression parser error messages (NFC) #10399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
augusto2112
approved these changes
Apr 1, 2025
| @@ -765,12 +766,13 @@ bool SwiftUserExpression::Parse(DiagnosticManager &diagnostic_manager, | |||
| std::static_pointer_cast<SwiftASTContextForExpressions>(swift_ast_ctx); | |||
|
|
|||
| if (!m_swift_ast_ctx) | |||
| return error("could not create a Swift AST context"); | |||
| return error("could not initialize Swift compiler", | |||
There was a problem hiding this comment.
I think there's a space missing here, it will print "compilerrun"
There was a problem hiding this comment.
No, these are separate messages.
| @@ -765,12 +766,13 @@ bool SwiftUserExpression::Parse(DiagnosticManager &diagnostic_manager, | |||
| std::static_pointer_cast<SwiftASTContextForExpressions>(swift_ast_ctx); | |||
|
|
|||
| if (!m_swift_ast_ctx) | |||
| return error("could not create a Swift AST context"); | |||
| return error("could not initialize Swift compiler", | |||
| "run 'swift-healthcheck' for more details"); | |||
There was a problem hiding this comment.
These are user facing right? Running swift-healthcheck won't produce anything useful to the user, right? I'd change it to run swift-healthcheck and file a bug with the file.
There was a problem hiding this comment.
It is user-facing, but it contains, for example compiler errors that users are expected to be familiar with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://143448485