[llvm][cas] Extend on-disk CAS validation to ActionCache #10406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate the ActionCache hash-mapped trie structure and sanity check the resulting values. Unlike the CAS itself there is no direct way to check the values are "correct", but at least we can check for invalid zero offsets, which is what we would get if we dropped page writes or truncated the file.
|
@swift-ci please test llvm |
cachemeifyoucan
approved these changes
Apr 2, 2025
|
The hanging test on macOS appears to be in clangd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate the ActionCache hash-mapped trie structure and sanity check the resulting values. Unlike the CAS itself there is no direct way to check the values are "correct", but at least we can check for invalid zero offsets, which is what we would get if we dropped page writes or truncated the file.