6.2: [Coro] Retcon.Dynamic: Cap spill alignment. #10455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply to dynamic retcon coroutines the machinery added in 2937f8d for async coroutines. And test aligning of allocas with large alignments. rdar://148782254
|
@swift-ci please test |
|
@swift-ci please test windows platform |
tbkka
approved these changes
Apr 8, 2025
|
@swift-ci please test windows platform |
1 similar comment
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Cap alignment of spills to dynamic retcon coro frame.
Scope: Affects dynamic retcon once coroutines only.
Issue: rdar://148782254
Original PR: #10449
Risk: Low, only affects the dynamic retcon once coro ABI which is only used by swift's coroutine accessors feature.
Testing: Added test.
Reviewer: Arnold Schwaighofer ( @aschwaighofer )