Skip to content

[Cherry-pick into swift/release/6.2] [dsymutil] Avoid copying binary swiftmodules built from textual #10460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adrian-prantl
Copy link

commit 96f95c9d89d8a1784d3865fa941fb1c510f4e2d7
Author: Adrian Prantl <[email protected]>
Date:   Thu Apr 3 16:25:43 2025 -0700

    [dsymutil] Avoid copying binary swiftmodules built from textual
    
    .swiftinterface files into the dSYM bundle. These typically come only
    from the SDK (since textual interfaces require library evolution) and
    thus are a waste of space to copy into the bundle.
    
    The information about this is being parsed out of the control block,
    which means duplicating 5 constants from the Swift frontend. If a file
    cannot be parsed, dsymutil errs on the side of copying the file
    anyway.
    
    rdar://138186524
    
    Relanding with additional linker dependency and moving the test into
    the right target subdirectory.

commit 320c13e09aea3234a171eaebfc2b263bd88a9869
Author: Adrian Prantl <[email protected]>
Date:   Tue Apr 8 13:05:36 2025 -0700

    [dsymutil] Add missing dependency

.swiftinterface files into the dSYM bundle. These typically come only
from the SDK (since textual interfaces require library evolution) and
thus are a waste of space to copy into the bundle.

The information about this is being parsed out of the control block,
which means duplicating 5 constants from the Swift frontend. If a file
cannot be parsed, dsymutil errs on the side of copying the file
anyway.

rdar://138186524

Relanding with additional linker dependency and moving the test into
the right target subdirectory.

(cherry picked from commit 96f95c9)
(cherry picked from commit 320c13e)
@adrian-prantl adrian-prantl requested a review from a team as a code owner April 8, 2025 22:33
@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl adrian-prantl merged commit 30a56da into swiftlang:swift/release/6.2 Apr 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants