Skip to content

[lldb] Avoid costly SwiftASTContext fallback for builtin types #10461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

[lldb] Avoid costly SwiftASTContext fallback for builtin types #10461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,9 @@ SwiftLanguageRuntime::GetNumChildren(CompilerType type,
//
// However, some imported Clang types (specifically enums) will also produce
// `BuiltinTypeInfo` instances. These types are not to be handled here.
if (TypeSystemSwiftTypeRef::IsBuiltinType(type))
return 0;

LLDB_LOG(GetLog(LLDBLog::Types),
"{0}: unrecognized builtin type info or this is a Clang type "
"without DWARF debug info",
Expand Down Expand Up @@ -1162,6 +1165,9 @@ SwiftLanguageRuntime::GetIndexOfChildMemberWithName(
}
}
case TypeInfoKind::Builtin: {
if (TypeSystemSwiftTypeRef::IsBuiltinType(type))
return {SwiftLanguageRuntime::eNotFound, {}};

CompilerType clang_type;
if (ts.IsImportedType(type.GetOpaqueQualType(), &clang_type)) {
clang_type = GetTypedefedTypeRecursive(clang_type);
Expand Down