[🍒 swift/release/6.2] Fix issue where target.source-map didn't apply to SwiftASTContext::Create #10529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eateInstance This specifically is for SwiftASTContext::CreateInstance with a TypeSystemSwiftTypeRef, the other version works as expected.
|
@swift-ci please test |
adrian-prantl
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifically is for SwiftASTContext::CreateInstance with a TypeSystemSwiftTypeRef, the other version works as expected.
Explanation:
This fixes an issue in one version SwiftASTContext::CreateInstance where source mappings were not properly applied like they are in the ohter version.
Scope:
Very limited, fixes inconsistent application of
target.source-map, no other changesIssues:
We're seeing ClangImporter failures due to the remappings not being applied, but haven't filed upstream issues.
Original PRs: Fix issue where target.source-map didn't apply to SwiftASTContext::CreateInstance #10527
Risk: Low, only applies to lldb sessions with
target.source-mapand is a correctness fix. The previous behavior is incorrect.Testing: All tests passed. Tried to update TestSwiftRewriteClangPaths but was able to trigger the modified version of
SwiftASTContext::CreateInstance, I think a new test suite can be added / this test could be modified in a follow up if needed.Reviewers:
Not yet approved, TBD