Skip to content

Re-land "[lldb] Customize the statusline for the Swift REPL" #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JDevlieghere
Copy link

Reverts #10483 and re-lands #10474.

@JDevlieghere JDevlieghere requested a review from a team as a code owner April 23, 2025 23:23
@JDevlieghere
Copy link
Author

@swift-ci test

This fixes a data race between the main thread and the default event
handler thread. The statusline format option value was protected by a
mutex, but it was returned as a pointer, allowing one thread to access
it while another was modifying it.

Avoid the data race by returning format values by value instead of by
pointer.

(cherry picked from commit 6760857)
@JDevlieghere JDevlieghere force-pushed the revert-10483-revert-10474-rdar148769820 branch from 03c4539 to 488438e Compare June 4, 2025 02:21
@JDevlieghere
Copy link
Author

@swift-ci test

@JDevlieghere JDevlieghere merged commit 7a2d13e into swift/release/6.2 Jun 5, 2025
3 checks passed
@JDevlieghere JDevlieghere deleted the revert-10483-revert-10474-rdar148769820 branch June 5, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants