[lldb] Fix local buffer not being popped #10718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
commented
May 21, 2025
augusto2112
commented
- Explanation: On a recent change in GetDynamicTypeAndAddress_Existential, the local buffer was being pushed but never popped. This fixes the issue by introducing a new RAII data structure that will pop the local buffer when out of scope.
- Scope: Fixes potentially failing dynamic type resolution.
- Issues: rdar://148137949
- Risk: Low. This just makes sure the local buffer is popped after every time it is pushed, and the patch is fairly straightforward.
- Testing: Added a new test.
- Reviewers: @adrian-prantl
On a recent change in GetDynamicTypeAndAddress_Existential, the local buffer was being pushed but never popped. This fixes the issue by introducing a new RAII data structure that will pop the local buffer when out of scope. rdar://148137949
|
@swift-ci test |
| uint64_t local_buffer_size) { | ||
| MemoryReaderLocalBufferHolder::~MemoryReaderLocalBufferHolder() { | ||
| if (m_memory_reader) | ||
| m_memory_reader->popLocalBuffer(); |
| MemoryReaderLocalBufferHolder(LLDBMemoryReader *memory_reader) | ||
| : m_memory_reader(memory_reader) {} | ||
|
|
||
| LLDBMemoryReader *m_memory_reader; |
There was a problem hiding this comment.
Suggested change
| LLDBMemoryReader *m_memory_reader; | |
| LLDBMemoryReader *m_memory_reader = nullptr; |
| class LLDBMemoryReader; | ||
| class MemoryReaderLocalBufferHolder { | ||
| public: | ||
| MemoryReaderLocalBufferHolder() : m_memory_reader(nullptr) {} |
There was a problem hiding this comment.
Suggested change
| MemoryReaderLocalBufferHolder() : m_memory_reader(nullptr) {} | |
| MemoryReaderLocalBufferHolder() = default; |
adrian-prantl
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.