Skip to content

[lldb][Modules] Fix error handling of loadModuleMapFile #10733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Michael137
Copy link

loadModuleMapFile returns true on error. This seems to have always been an issue? This is now preventing me from fixing a different modules related issue. So this patch checks the return value correctly.

`loadModuleMapFile` returns true on error. This seems to have always been an issue? This is now preventing me from fixing a different modules related issue. So this patch checks the return value correctly.
@Michael137 Michael137 requested a review from a team as a code owner May 23, 2025 09:52
@Michael137
Copy link
Author

@swift-ci test

@adrian-prantl adrian-prantl merged commit e3fe1f9 into swift/release/6.2 May 23, 2025
3 checks passed
@adrian-prantl adrian-prantl deleted the lldb/modules-return-value-fix-to-6.2 branch May 23, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants