Skip to content

[Clang][Sema] Emit noescape diagnostic with a type name instead of 0 #10747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[Clang][Sema] Emit noescape diagnostic with a type name instead of 0 #10747

merged 1 commit into from
May 28, 2025

Conversation

egorzhdan
Copy link

rdar://152087076

@egorzhdan egorzhdan requested a review from hnrklssn May 27, 2025 15:22
@egorzhdan egorzhdan requested a review from a team as a code owner May 27, 2025 15:22
@egorzhdan
Copy link
Author

@swift-ci please test

@egorzhdan egorzhdan mentioned this pull request May 27, 2025
Merged
@egorzhdan egorzhdan requested a review from Xazax-hun May 28, 2025 12:10
@egorzhdan egorzhdan merged commit 990b92b into stable/20240723 May 28, 2025
3 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/0-is-invalid branch May 28, 2025 12:10
@egorzhdan egorzhdan mentioned this pull request May 28, 2025
Merged
@drodriguez
Copy link

drodriguez commented May 29, 2025 •
edited
Loading

#9789 changed a couple tests that include the 0 is invalid messaging in SemaCXX and SemaObjCXX. Shouldn't those also be fixed?

I just found #10757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnrklssn hnrklssn hnrklssn approved these changes

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egorzhdan @drodriguez @hnrklssn