🍒[6.2][clang][cas] Handle CAS errors from OutputFile::keep() #10776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When finishing output files we need to handle all possible Error kinds or we will have undefined behaviour. In particular, if storing to the CAS failed we could silently fail to add the main output leading to mysterious downstream failures if we tried to replay that compilation, or for modules when we tried to load the pcm contents. rdar://151077068 (cherry picked from commit f2b5016)
|
@swift-ci please test llvm |
|
@swift-ci please test |
akyrtzi
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::handleAllErrorswithout handling every possible error. In practice, this was causing us to silently drop the output file and cause mysterious downstream failures during module import or cache hit replay.handleAllErrorsthat covers any remaining errors that fall through the other handlers.