🍒 [lldb] make lit use the same PYTHONHOME for building and testing #10875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-zablit
commented
Jun 19, 2025
charles-zablit
commented
- [lldb] make lit use the same PYTHONHOME for building and testing llvm/llvm-project#143183
…ng (llvm#143756) When testing LLDB, we want to make sure to use the same Python as the one we used to build it. This patch uses the CMake variable `Python3_ROOT_DIR` to add the correct Python to the `PATH` in LLDB lit tests, in order to ensure of this. Please see swiftlang/swift#82063 for the original issue. This is a continuation of swiftlang/swift#82063.
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please test windows |
adrian-prantl
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.