Skip to content

[upstreaming] Revert added fixme to UserExpression.h #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2019
Merged

[upstreaming] Revert added fixme to UserExpression.h #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lldb/include/lldb/Expression/UserExpression.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,6 @@ class UserExpression : public Expression {
return lldb::ExpressionVariableSP();
}

// FIXME: This doesn't make sense in UserExpression. It is only used in
// UserExpression::Evaluate.
virtual lldb::ModuleSP GetJITModule() { return lldb::ModuleSP(); }

/// Evaluate one expression in the scratch context of the target passed in
Expand Down